lkml.org 
[lkml]   [2008]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] pci: add misrouted interrupt error handling
Date
On Tuesday, August 5, 2008 2:54 pm James Bottomley wrote:
> > or somesuch. That seems just as simple for driver writers as your
> > initial patch, and the function is named in accordance with what it
> > actually does, rather than what it's used for...
>
> It could, but if the bridge is the culprit (as it usually is for MSI
> problems), this print won't help identify it.
>
> Therefore, rather than give driver writers a recipe for "print this and
> this and go to the bridge and print this", I'd rather have a single PCI
> callback that prints all the (hopefully) relevant information that will
> allow either fixing or blacklisting.

So in addition to the IRQ type check we need to dump some device topology
information... yeah that makes sense. I wonder if the driver core should
provide something like this. Greg? In the meantime we can definitely add
the IRQ type function.

Thanks,
Jesse


\
 
 \ /
  Last update: 2008-08-07 18:05    [W:0.107 / U:2.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site