lkml.org 
[lkml]   [2008]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ANNOUNCE] mdb-2.6.27-rc2-ia32-08-07-08.patch
Stefan Richter wrote:
> jmerkey@wolfmountaingroup.com wrote:
>> ftp://ftp.wolfmountaingroup.org/pub/mdb/mdb-2.6.27-rc2-ia32-08-07-08.patch
...
>> +typedef struct _RLOCK
>> +{
>> +#if defined(CONFIG_SMP)
>> + spinlock_t lock;
>> +#endif
>> + unsigned long flags;
>> + unsigned long processor;
>> + unsigned long count;
>> +} rlock_t;
...
> The accessors rspin_lock() and rspin_try_lock() peek into spinlock_t and
> may therefore not be fully portable. Also, they and rspin_unlock()
> don't look SMP safe:
...
>> + if (rlock->lock.raw_lock.slock && rlock->processor == proc)

Correction: They _are_ not portable. Look at the first hit in
http://lxr.linux.no/linux+v2.6.26/+code=raw_spinlock_t .
--
Stefan Richter
-=====-==--- =--- --===
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2008-08-07 18:03    [W:0.578 / U:2.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site