lkml.org 
[lkml]   [2008]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: BUG in VFS or block layer
On Wed, 6 Aug 2008, Andrew Morton wrote:

> > > So... would you be able to verify that the USB, layer is correctly
> > > calling bio->bi_end_io() for the offending requests?
> >
> > The USB layer doesn't handle that; the SCSI layer takes care of it.
> > Possibly the I/O error confuses the code in and around
> > scsi_end_request(). I'll have to do some testing to find out.
> >
>
> Well... looking at your patch to
> drivers/usb/gadget/file_storage.c:do_read(), it appears that
> do_scsi_command() just drops do_read()'s error code on the floor rather
> than returning it to the scsi layer?

No, you misunderstand. file_storage.c is a peripheral driver, not a
host device driver. It doesn't communicate directly with the SCSI
layer and it doesn't handle any BIO requests. You're thinking of
usb-storage, not file_storage.

Alan Stern



\
 
 \ /
  Last update: 2008-08-07 16:21    [W:0.051 / U:10.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site