Messages in this thread | | | Subject | Re: [patch] PCI: check the return value of device_create_bin_file() in pci_create_bus() | From | Michael Ellerman <> | Date | Thu, 07 Aug 2008 10:30:26 +1000 |
| |
On Thu, 2008-08-07 at 09:30 +1000, Simon Horman wrote: > Check the return value of device_create_bin_file in pci_create_bus and > unwind if necessary. Don't propagate error to caller, as failure to create > these files shouldn't prevent PCI from being initialised. > > Cc: Sven Wegener <sven.wegener@stealer.net> > Cc: Michael Ellerman <michael@ellerman.id.au> > Cc: Matthew Wilcox <matthew@wil.cx> > Signed-off-by: Simon Horman <horms@verge.net.au>
I hate to prolong the pain, but wasn't the plan to print a big fat warning so that it's clear the system is not 100% happy.
cheers
-- Michael Ellerman OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person [unhandled content-type:application/pgp-signature] | |