lkml.org 
[lkml]   [2008]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Resurect proper handling of maxcpus= kernel option
> From: Max Krasnyansky <maxk@qualcomm.com>
>
> For some reason we had redundant parsers registered for maxcpus=.
> One in init/main.c and another in arch/x86/smpboot.c
> So I nuked the one in arch/x86.
>
> Also 64-bit kernels used to handle maxcpus= as documented in
> Documentation/cpu-hotplug.txt. CPUs with 'id > maxcpus' are initialized
> but not booted. 32-bit version for some reason ignored them even though
> all the infrastructure for booting them later is there.
>
> In the current mainline both 64 and 32 bit versions are broken. I'm
> too lazy to look through git history but I'm guessing it happened as
> part of the i386 and x86_64 unification.
>
> This patch restores the correct behaviour. I've tested x86_64 version on
> 4- and 8- way Core2 and 2-way Opteron based machines. Various config
> combinations SMP, !SMP, CPU_HOTPLUG, !CPU_HOTPLUG.
> Booted with maxcpus=1 and maxcpus=4, etc. Everything is working as expected.
>
> I cannot test 32-bit version (no 32-bit machines here).
>
> Signed-off-by: Max Krasnyansky <maxk@qualcomm.com>
> Cc: lizf@cn.fujitsu.com
> Cc: jeff.chua.linux@gmail.com

I just realized that I managed to screw up my From: email address in
git-send-email command line. Please reply to maxk@qualcomm.com.

Max


\
 
 \ /
  Last update: 2008-08-06 22:25    [W:0.108 / U:1.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site