lkml.org 
[lkml]   [2008]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/2] ide-{floppy,tape}: remove request stack
From
On Wed, Aug 06, 2008 at 08:33:24PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Wed, Aug 6, 2008 at 7:14 PM, Bartlomiej Zolnierkiewicz
> <bzolnier@gmail.com> wrote:
>
> [...]
>
> > ---
> > pc stack can also be removed with a bit of care, we just need sth like:
> >
> > - add request_sense_pc (request_sense_rq alike)
> >
> > - dynamically allocate pc-s for blk_{fs,pc}_request() in ide-floppy.c
> > and for REQ_IDETAPE_{READ,WRITE} in ide-tape.c
> >
> > - add PC_FLAG_DYN for dynamically allocated pc-s
> >
> > - (the difficult part) figure out where to put freeing of dynamic pc-s
> >
> > Borislav, AFAIR you had some patches doing dynamic pc/rq-s?
> > Maybe it would be possible to dust off just their rq-parts?
>
> Please disregard above comments -- I found a better way to deal with rq stack.

Looks good so far, even slimmer than the dynamic alloc ones i'd done. Will test
with ide-floppy on the weekend.

--
Regards/Gruss,
Boris.


\
 
 \ /
  Last update: 2008-08-06 21:41    [W:0.045 / U:12.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site