Messages in this thread | | | Subject | Re: [PATCH] hugetlb: call arch_prepare_hugepage() for surplus pages | From | gerald_IMAP <> | Date | Wed, 06 Aug 2008 15:48:50 +0200 |
| |
On Tue, 2008-08-05 at 13:32 -0700, Andrew Morton wrote: > > --- > > > > mm/hugetlb.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > Index: linux/mm/hugetlb.c > > =================================================================== > > --- linux.orig/mm/hugetlb.c > > +++ linux/mm/hugetlb.c > > @@ -565,7 +565,7 @@ static struct page *alloc_fresh_huge_pag > > huge_page_order(h)); > > if (page) { > > if (arch_prepare_hugepage(page)) { > > - __free_pages(page, HUGETLB_PAGE_ORDER); > > + __free_pages(page, huge_page_order(h)); > > As Nick pointed out, this is an unrelated bugfix. I changelogged it. > Really it should have been two patches.
Ok, thanks. I didn't see it as a bugfix because it doesn't make any difference on s390, and nobody else is using arch_prepare_hugepage() so far. But of course this may change, so I should have made two patches.
> afaict the second fix is needed in 2.6.26.x (but not 2.6.25.x), but > this patch is not applicable to 2.6.26.x. > > So if you want this fix to be backported into 2.6.26.x, please send a > suitable version of it to stable@kernel.org.
Right, this was missing from the beginning. It affects s390 only, so I'll check if we need a backport.
Thanks, Gerald
| |