Messages in this thread Patch in this message | | | Date | Wed, 6 Aug 2008 10:23:52 +0100 | From | Matthew Garrett <> | Subject | [PATCH v2 1/2] eeepc-laptop: Fix user after free |
| |
eeepc-laptop uses the hwmon struct after unregistering the device, causing an oops on module unload. Flip the ordering to fix.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
---
commit 95f4bc41ef256b8e3dfa94cabe1faf0776ac988c Author: Matthew Garrett <mjg59@srcf.ucam.org> Date: Mon Aug 4 17:57:40 2008 +0100
Fix use after free
diff --git a/drivers/misc/eeepc-laptop.c b/drivers/misc/eeepc-laptop.c index 9e8d79e..facdb98 100644 --- a/drivers/misc/eeepc-laptop.c +++ b/drivers/misc/eeepc-laptop.c @@ -553,9 +553,9 @@ static void eeepc_hwmon_exit(void) hwmon = eeepc_hwmon_device; if (!hwmon) return ; - hwmon_device_unregister(hwmon); sysfs_remove_group(&hwmon->kobj, &hwmon_attribute_group); + hwmon_device_unregister(hwmon); eeepc_hwmon_device = NULL; } -- Matthew Garrett | mjg59@srcf.ucam.org
| |