Messages in this thread | | | Subject | Re: [PATCH 10/10] sparc64: use iommu_num_pages function in IOMMU code | From | Benjamin Herrenschmidt <> | Date | Tue, 05 Aug 2008 18:23:29 +1000 |
| |
> I didn't want to change multiple architectures with a single patch so I > splitted it up. The whole renaming in the beginning is to make the patch > series bisectable. But if its no problem to change multiple > architectures with one patch I will those changes in a single patch next > time.
I wouldn't say there's a strict rule. It's a balance to find between the complexity of the patch, the risk of breaking archs, etc...
In your case, the added churn of going through a temporary renamed helper represents more, imho, than the risk of breakage of what is a fairly trivial patch in the first place. Also, it only affects a few archs. So it's simpler or everybody to deal with a single patch even if that means it -might- need a rev or two in case it does indeed break something...
Ben.
| |