Messages in this thread | | | Subject | Re: [PATCH] drm: Add GEM ("graphics execution manager") to i915 driver. | From | Eric Anholt <> | Date | Tue, 05 Aug 2008 18:11:56 -0700 |
| |
On Fri, 2008-08-01 at 08:44 -0700, Randy Dunlap wrote: > On Thu, 31 Jul 2008 23:58:39 -0700 Eric Anholt wrote: > > > GEM allows the creation of persistent buffer objects accessible by the > > graphics device through new ioctls for managing execution of commands on the > > device. The userland API is almost entirely driver-specific to ensure that > > any driver building on this model can easily map the interface to individual > > driver requirements. > > > > GEM is used by the 2d driver for managing its internal state allocations and > > will be used for pixmap storage to reduce memory consumption and enable > > zero-copy GLX_EXT_texture_from_pixmap, and in the 3d driver is used to enable > > GL_EXT_framebuffer_object and GL_ARB_pixel_buffer_object. > > "the 2d driver" ... "the 3d driver". > Just curious: Is there only one of each of these?
"The 2D driver" means xf86-video-intel xorg driver in userland. "The 3D driver" means i9[16]5_dri.so mesa driver in userland.
> > diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/drm/drm_agpsupport.c > > index aefa5ac..2639be2 100644 > > --- a/drivers/gpu/drm/drm_agpsupport.c > > +++ b/drivers/gpu/drm/drm_agpsupport.c > > @@ -33,6 +33,7 @@ > > > > #include "drmP.h" > > #include <linux/module.h> > > +#include <asm/agp.h> > > > > #if __OS_HAS_AGP > > > > @@ -452,4 +453,52 @@ int drm_agp_unbind_memory(DRM_AGP_MEM * handle) > > return agp_unbind_memory(handle); > > } > > > > -#endif /* __OS_HAS_AGP */ > > +/** > > In the kernel source tree, "/**" means "beginning of kernel-doc notation", > so please don't use it when kernel-doc isn't being used. > (in multiple places/files)
The codebase this is coming from uses doxygen. I hadn't checked to see if all the doxygen was converted to kernel-doc.
-- Eric Anholt eric@anholt.net eric.anholt@intel.com
[unhandled content-type:application/pgp-signature] | |