Messages in this thread | | | Date | Tue, 05 Aug 2008 09:33:33 -0500 | From | Christoph Lameter <> | Subject | Re: [PATCH] SLUB: detach SLUB_DEBUG and SYSFS |
| |
Alexey Dobriyan wrote: > On Mon, Aug 04, 2008 at 05:10:37PM +0300, Pekka Enberg wrote: >> Christoph Lameter wrote: >>> Pekka Enberg wrote: >>>> Alexey Dobriyan wrote: >>>>> Right now, SYSFS=n means no SLUB debugging, no even basic poisoning, >>>>> to hell with tunables. >>>> Applied, thanks! >>> Do not apply. This partially reverts an earlier commit and would cause >>> build >>> issues because the #ifdef parts in slub.c were not reverted. >> Aww, crap. OK, taking it out. > > OK, I'll test-compile it to death.
Not sure what the point would be. If you look at the commit you are reverting then its clear what configurations will break,
> For now, do you agree that SYSFS=n users shouldn't be discriminated > against poisoning?
If you want a minimal memory footprint then I thought that also implies that the debug code would not be compiled in?
> As real world situation, NET_NS feature which is currently in > active development doesn't work with SYSFS, so it was a bit of cold > shower to realise that I did much testing of conntracking in netns > without poisoning. :-(
Ohh.. There are kernel features that conflict with SYSFS?
| |