lkml.org 
[lkml]   [2008]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/3] dentries: Always use list_del_init() when removing a dentry from the lru
Christoph Lameter wrote:
> The patch restores what commit 4a0962abd187df29b7d1378b2f372a55667d54c0
> already implemented. The feature was subsequently clobbered by
> commit da3bbdd4632c0171406b2677e31494afa5bde2f8
>
> Before this patch some execution path use list_del() instead of
> list_del_init() which results in inconsitencies in the state of d_lru
> when the object is freed.
>
> The performance of list_del_init() and list_del() is the same.
> So lets just have one dentry removal function named dentry_lru_del() that always
> does a list_del_init().
>
> The result of this patch is that dentry->d_lru is now always empty when a
> dentry is freed. The dentry defragmentation patch depends on a defined state
> of a dentry on free.
>
> Signed-off-by: Christoph Lameter <cl@linux-foundation.org>

Applied, thanks!


\
 
 \ /
  Last update: 2008-08-31 16:57    [W:0.081 / U:5.140 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site