lkml.org 
[lkml]   [2008]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs
    On Sun, Aug 31, 2008 at 8:06 PM, Paul E. McKenney
    <paulmck@linux.vnet.ibm.com> wrote:
    > On Sun, Aug 31, 2008 at 07:53:32PM +0200, Vegard Nossum wrote:
    >> On Sun, Aug 31, 2008 at 7:51 PM, Paul E. McKenney
    >> <paulmck@linux.vnet.ibm.com> wrote:
    >> >> > @@ -751,6 +749,7 @@ int __cpu_disable(void)
    >> >> > remove_siblinginfo(cpu);
    >> >> > cpu_clear(cpu, cpu_online_map);
    >>
    >> Here ^^^
    >>
    >> >> > fixup_irqs();
    >> >> > + cpu_clear(cpu, cpu_online_map);
    >> >> > local_flush_tlb_all();
    >> >> > cpu_clear(cpu, cpu_callin_map);
    >> >> > return 0;
    >> >>
    >> >> Hm. Maybe my eyes are going bad. But isn't that now clearing the cpu
    >> >> both before and after calling fixup_irqs()?
    >> >
    >> > I don't believe so... I removed the earlier one and added the later
    >> > one. Or is there another one hidden somewhere that I missed?
    >>
    >> See marker above. It's not removed, is it?
    >
    > Right you are!!! There were two to begin with, and I moved the first
    > one only. The attached updated patch removes the extra one.

    Good, I am not blind yet! (Though I did have to look more than once.)

    On the other hand... Paul; human after all!


    Vegard

    --
    "The animistic metaphor of the bug that maliciously sneaked in while
    the programmer was not looking is intellectually dishonest as it
    disguises that the error is the programmer's own creation."
    -- E. W. Dijkstra, EWD1036


    \
     
     \ /
      Last update: 2008-08-31 21:11    [W:0.050 / U:0.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site