Messages in this thread | | | Date | Sun, 31 Aug 2008 19:53:32 +0200 | From | "Vegard Nossum" <> | Subject | Re: [PATCH] prevent ia64 from invoking irq handlers on offline CPUs |
| |
On Sun, Aug 31, 2008 at 7:51 PM, Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote: >> > @@ -751,6 +749,7 @@ int __cpu_disable(void) >> > remove_siblinginfo(cpu); >> > cpu_clear(cpu, cpu_online_map);
Here ^^^
>> > fixup_irqs(); >> > + cpu_clear(cpu, cpu_online_map); >> > local_flush_tlb_all(); >> > cpu_clear(cpu, cpu_callin_map); >> > return 0; >> >> Hm. Maybe my eyes are going bad. But isn't that now clearing the cpu >> both before and after calling fixup_irqs()? > > I don't believe so... I removed the earlier one and added the later > one. Or is there another one hidden somewhere that I missed?
See marker above. It's not removed, is it?
Vegard
-- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036
| |