lkml.org 
[lkml]   [2008]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] pata_legacy: export functionality to ide
> The code in question is 65 LOC total (43 LOC without counting comments)
> so having a shared library just for it sounds like an overkill and we may

People expect code in C files, so in headers it gets missed as well as
dumped in a directory with no correlation between file name and subsystem.

> just copy that one function from pata_legacy to ide_generic instead.

If you are going to #include two copies you might as well just copy it.

Alan


\
 
 \ /
  Last update: 2008-08-03 16:01    [W:0.124 / U:1.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site