lkml.org 
[lkml]   [2008]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC, 2.6.26.2-rc1] posix timers: release_posix_timer: kill the bogus put_task_struct(->it_process)
On 08/03, Sven Wegener wrote:
>
> On Sat, 2 Aug 2008, Oliver Pinter wrote:
>
> > It is an RFC for sending this patch for stable, when this patch needed, then send ACK and CC stable,
> > if not then send NAK.
>
> I'd say big NAK. Have you ever looked at the full commit message and patch
> at all? It says "release_posix_timer() can't be called with ->it_process
> != NULL.". Point. The rest is the explanation why this can't happen. And
> looking at the patch, we see that it just removes code that actually never
> gets executed under the mentioned preconditions. It's a pure cleanup patch
> and doesn't qualify for -stable. Same goes for the other posix timer patch
> you mailed out.

I agree. Perhaps the changelog was badly written...

These 2 patches are just cleanups which remove the dead code,
this is not the -stable material.

Oleg.



\
 
 \ /
  Last update: 2008-08-03 12:37    [W:0.051 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site