lkml.org 
[lkml]   [2008]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: gspca_zc3xx oops - 2.6.27-rc1
On Sun, Aug 03, 2008 at 03:52:24AM -0400, Parag Warudkar wrote:
> On Sun, Aug 3, 2008 at 3:37 AM, Rabin Vincent <rabin@rab.in> wrote:
[..]
> > Now sd->gamma shouldn't be zero because in sd_ctrls, the minimum value for it
> > is set to 1. This range should be checked by vidioc_s_ctrl in gspca.c, and we
> > have this there:
> >
> > if (ctrl->value < ctrls->qctrl.minimum
> > && ctrl->value > ctrls->qctrl.maximum)
> > return -ERANGE;
> >
>
> Sounds more appropriate but I am not sure how vidioc_s_ctrl leads to
> the call trace in the OOPS - at least it doesn't show up there.

The call trace is for the ioctl which starts the capturing. However,
the gamma value is not set when starting the capturing, but would have
been set earlier using a separate ioctl -- that one would have gone
through vidioc_s_ctrl.

Rabin


\
 
 \ /
  Last update: 2008-08-03 12:29    [W:0.104 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site