lkml.org 
[lkml]   [2008]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: pcm_native: remove unused label
On Sun, 3 Aug 2008, Marcin Slusarz wrote:

> gcc warns about it:
> sound/core/pcm_native.c: In function 'snd_pcm_fasync':
> sound/core/pcm_native.c:3262: warning: label 'out' defined but not used
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jaroslav Kysela <perex@perex.cz>
> ---
> sound/core/pcm_native.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> index c49b9d9..333cff6 100644
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -3259,7 +3259,6 @@ static int snd_pcm_fasync(int fd, struct file * file, int on)
> runtime = substream->runtime;
>
> err = fasync_helper(fd, file, on, &runtime->fasync);
> -out:
> unlock_kernel();
> if (err < 0)
> return err;

Uhm, no, there's

snd_assert(substream != NULL, goto out);

one line above your context. The snd_assert() macro will only include the
second argument with CONFIG_SND_DEBUG, without CONFIG_SND_DEBUG it just
evaulates the first parameter and triggers the warning.

Sven


\
 
 \ /
  Last update: 2008-08-03 19:31    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean