lkml.org 
[lkml]   [2008]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] x86: Coding style fixes to arch/x86/kernel/bios_uv.c
    Paolo Ciarrocchi wrote:
    >
    > diff --git a/arch/x86/kernel/bios_uv.c b/arch/x86/kernel/bios_uv.c
    > index c639bd5..100e759 100644
    > --- a/arch/x86/kernel/bios_uv.c
    > +++ b/arch/x86/kernel/bios_uv.c
    > @@ -25,11 +25,21 @@ x86_bios_strerror(long status)
    > {
    > const char *str;
    > switch (status) {
    > - case 0: str = "Call completed without error"; break;
    > - case -1: str = "Not implemented"; break;
    > - case -2: str = "Invalid argument"; break;
    > - case -3: str = "Call completed with error"; break;
    > - default: str = "Unknown BIOS status code"; break;
    > + case 0:
    > + str = "Call completed without error";
    > + break;
    > + case -1:
    > + str = "Not implemented";
    > + break;
    > + case -2:
    > + str = "Invalid argument";
    > + break;
    > + case -3:
    > + str = "Call completed with error";
    > + break;
    > + default:
    > + str = "Unknown BIOS status code";
    > + break;
    > }
    > return str;
    > }

    This should be an array in the first place...

    -hpa


    \
     
     \ /
      Last update: 2008-08-03 06:05    [W:2.267 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site