Messages in this thread | | | Date | Fri, 29 Aug 2008 13:04:55 -0700 (PDT) | Subject | Re: [Bug #11342] Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected | From | David Miller <> |
| |
From: Linus Torvalds <torvalds@linux-foundation.org> Date: Fri, 29 Aug 2008 09:14:44 -0700 (PDT)
> Well, it probably boots because it doesn't really seem to _change_ much of > anything. > > Things like this: > > -static inline void arch_send_call_function_ipi(cpumask_t mask) > +static inline void arch_send_call_function_ipi(cpumask_t *mask) > { > - smp_ops.send_call_func_ipi(mask); > + smp_ops.send_call_func_ipi(*mask); > } > > will still do that stack allocation at the time of the call. You'd have to > pass the thing all the way down as a pointer..
True, but we have to get there one step at a time.
BTW, sparc64 already wants a pointer here, so it's completely ready for this:
void arch_send_call_function_ipi(cpumask_t mask) { xcall_deliver((u64) &xcall_call_function, 0, 0, &mask); }
| |