lkml.org 
[lkml]   [2008]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] FUSE: implement ioctl support
Miklos Szeredi wrote:
>> Hmmm... I was trying to stay within similar operation mechanics as other
>> ops. Directly accessing the caller's memory has performance benefits
>> but that benefit can also be used by reads and writes. So, if we're
>> gonna do direct memory access, maybe doing it in more generic way is a
>> better idea?
>
> On the contrary: playing VM games is going to be slow. I think this
> approach is best suited for generic ioctl support because it
> simplifies the kernel part. I'd hate to add all that complexity to
> the kernel if not absolutely necessary.

Well, it's only 240 lines with good amount of comments and iovec copying
function. The ioctl itself isn't too complex. I'm a bit skeptical
about direct access. It can easily introduce security vulnerabilities
as there really is no way to hold a pid.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2008-08-28 20:37    [W:0.099 / U:11.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site