lkml.org 
[lkml]   [2008]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] checkpatch: complex macros need to ignore comments
On Sat, Jul 05, 2008 at 08:44:35PM +0200, Jan Engelhardt wrote:
>
> On Wednesday 2008-07-02 13:31, Andy Whitcroft wrote:
>
> >Ensure we ignore comments in complex macro detection else we incorrectly
> >report this:
> >
> > #define PFM_GROUP_PERM_ANY -1 /* any user/group */
>
> Does it also catch this ugly piece from dcache.c?
>
>
> #define DCACHE_NFSFS_RENAMED 0x0002 /* this dentry has been "silly
> * renamed" and has to be
> * deleted on the last dput()
> */

Yeah it should indeed. A quick check with the current version seems to
confirm that.

-apw


\
 
 \ /
  Last update: 2008-08-28 17:21    [W:0.053 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site