Messages in this thread | | | Date | Thu, 28 Aug 2008 10:19:33 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH] block: kmalloc args reversed, small function definition fixes |
| |
On Thu, Aug 28, 2008 at 09:26:21AM +0200, Jens Axboe wrote: > On Wed, Aug 27 2008, Harvey Harrison wrote: > > Noticed by sparse: > > block/blk-softirq.c:156:12: warning: symbol 'blk_softirq_init' was not declared. Should it be static? > > block/genhd.c:583:28: warning: function 'bdget_disk' with external linkage has definition > > block/genhd.c:659:17: warning: incorrect type in argument 1 (different base types) > > block/genhd.c:659:17: expected unsigned int [unsigned] [usertype] size > > block/genhd.c:659:17: got restricted gfp_t > > block/genhd.c:659:29: warning: incorrect type in argument 2 (different base types) > > block/genhd.c:659:29: expected restricted gfp_t [usertype] flags > > block/genhd.c:659:29: got unsigned int > > block: kmalloc args reversed > > Woops, that kmalloc() is nasty. Thanks a lot, applied to for-2.6.28.
Umm, the gfp bit sounds like a clear 2.6.27 candidate.
| |