Messages in this thread | | | Subject | Re: [PATCH 2/2] Add support for > 2GiB MTD devices | From | Artem Bityutskiy <> | Date | Wed, 27 Aug 2008 08:40:17 +0300 |
| |
Hi Bruce,
On Tue, 2008-08-19 at 14:27 -0700, Bruce Leonard wrote: > +/* > + * Inline function for determining the size of the MTD device, independant > + * of old or new way of doing things. > + * > + */ > +static inline u_int64_t device_size(struct mtd_info *a) > +{ > + return a->num_eraseblocks == 0 ? a->size : a->num_eraseblocks * a->erasesize; > +}
I do not think it is a good idea to do multiplication every time we need MTD device size. It is unnecessarily large overhead in terms of speed and code size.
Did you consider a possibility of just making mtd->size 64 bit? Or using eraseblock:offset pairs instead of absolute address?
-- Best regards, Artem Bityutskiy (Битюцкий Артём)
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |