Messages in this thread | | | Date | Wed, 27 Aug 2008 09:15:50 -0700 | From | Greg KH <> | Subject | Re: [PATCH] USB: add USB test and measurement class driver |
| |
Ok, as I've responded to this multiple times, now summarizing so I make sure I got everything...
On Wed, Aug 27, 2008 at 10:56:36AM +0200, Oliver Neukum wrote: > Am Mittwoch 27 August 2008 02:05:01 schrieb Greg KH: > > > I've now added this to my tree, and any review comments are greatly > > welcome. > > Unfortunately the issues are not trivial. > > 1. USBTMC_SIZE_IOBUFFER > use 2048. 4096 means a multipage allocation
changed.
> 2. usbtmc_open race with disconnect > already mailed about
fixed.
> 3. read/write and, if you convert to unlocked_ioctl, need protection > against reentry
fixed and changed to unlocked_ioctl.
> 4. read, write & ioctl need protection against using a rebound interface > you add a mutex, that you need for (3) anyway to the descriptor and protected > by this mutex you set the interface and device pointers to null in disconnect > and check them in the affected methods
Should now be fixed.
> 5.get_capabilities > kmalloced buffer is never freed
fixed.
> 6. disconnect fails to remove sysfs attributes
fixed.
> 7. probe will report success even if usb_register_dev fails
fixed.
I'll post a new version now.
thanks a lot for the review, I really appreciate it.
greg k-h
| |