Messages in this thread | | | Date | Wed, 27 Aug 2008 04:17:05 -0700 (PDT) | Subject | Re: [PATCH] afs: fsclient.c sparse endian annotations of operation_ID | From | David Miller <> |
| |
From: David Howells <dhowells@redhat.com> Date: Wed, 27 Aug 2008 12:12:24 +0100
> Harvey Harrison <harvey.harrison@gmail.com> wrote: > > > + if (call->operation_ID != __constant_htonl(FSFETCHDATA64)) { > > Doesn't htonl() resolve to this for a constant argument? Following through > the definitions, it certainly looks like it ought to:
Yes it does.
The __constant_*() interfaces should only be uses for things that must be evaluated at compile time (static data initializations, switch statement case values etc.).
| |