Messages in this thread |  | | Date | Tue, 26 Aug 2008 12:53:48 -0600 | | From | "Latchesar Ionkov" <> | | Subject | Re: [V9fs-developer] [PATCH] 9p bug fix: return non-zero error value in p9_put_data |
| |
Acked-by: Latchesar Ionkov <lucho@ionkov.net>
On Tue, Aug 26, 2008 at 11:30 AM, Abhishek Kulkarni <kulkarni@lanl.gov> wrote: > p9_put_data is called by p9_create_twrite which expects it to return a > non-zero value on error. This was the reason why every p9_client_write > was failing. This patch also adds a check for buffer overflow in > p9_put_data. > > Signed-off-by: Abhishek Kulkarni <kulkarni@lanl.gov> > --- > net/9p/conv.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > diff --git a/net/9p/conv.c b/net/9p/conv.c > index 4454720..7f6db15 100644 > --- a/net/9p/conv.c > +++ b/net/9p/conv.c > @@ -451,8 +451,11 @@ p9_put_data(struct cbuf *bufp, const char *data, > int count, > unsigned char **pdata) > { > *pdata = buf_alloc(bufp, count); > + if (buf_check_overflow(bufp)) > + return -EIO; > + > memmove(*pdata, data, count); > - return count; > + return 0; > } > > static int > > > Thanks, > -- Abhishek > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > V9fs-developer mailing list > V9fs-developer@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/v9fs-developer >
|  |