Messages in this thread | | | Date | Tue, 26 Aug 2008 15:42:46 +0100 (BST) | From | "Maciej W. Rozycki" <> | Subject | Re: [RFC] Driver for Real Time Clock chip ST M41T65 |
| |
On Tue, 26 Aug 2008, Steven A. Falco wrote:
> I'd also like to know if I should submit a new driver or mod the existing > one. If I mod the existing one, should it be renamed, should I update the > Kconfig, existing defconfigs, etc?
Keeping the code base common is good for maintenance. Therefore for a minor differences like yours there is no doubt you better just add them to the existing driver.
For larger variations -- it depends, i.e. it's better to keep the common bits shared, unless the maintenance cost of such an approach exceeds that of the other one. Frequently it just boils down to doing it right which may not necessarily be easy. ;)
Maciej
| |