lkml.org 
[lkml]   [2008]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on Intel hosts

* Avi Kivity <avi@qumranet.com> wrote:

> Ingo Molnar wrote:
>> * Avi Kivity <avi@qumranet.com> wrote:
>>
>>
>>> Enabling Intel VT has the curious side effect whereby the INIT signal
>>> is blocked. Rather than comment on the wisdom of this side effect,
>>> this patch adds an emergency restart reboot notifier, and modifies
>>> the kvm reboot notifier to disable VT on emergency reboot.
>>>
>>
>> looks good to me - i was bitten by that problem on a testbox.
>>
>
> I'm a little worried about making emergency restart more complex.
>
> Another thing that worries me is that emergency_restart() doesn't
> reset the box -- it sends INIT. We could do better by using the ACPI
> FADT reset register (hopefully that's connected to RESET).

reboot was always a bit fragile - i think we should only do that if we
find a box where the FADT reset works better than the first-wave
approaches we try.

> Which seems to be what we want? Maybe we should just try acpi_reboot()
> before the other stuff.

perhaps in a separate commit, for v2.6.28 at the earliest.

Ingo


\
 
 \ /
  Last update: 2008-08-25 11:33    [W:0.056 / U:0.100 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site