lkml.org 
[lkml]   [2008]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 2/2] quicklist shouldn't be proportional to # of CPUs
Hi Mike, 

> >>> + num_cpus_per_node = cpus_weight_nr(node_to_cpumask(node));
>
> I think the more correct usage would be:
>
> {
> node_to_cpumask_ptr(v, node);
> num_cpus_per_node = cpus_weight_nr(*v);
> max /= num_cpus_per_node;
>
> return max(max, min_pages);
> }
>
> which should load 'v' with a pointer to the node_to_cpumask_map[node] entry
> [and avoid using stack space for the cpumask_t variable for those arch's
> that define a node_to_cpumask_map (or similar).] Otherwise a local cpumask_t
> variable '_v' is created to which 'v' is pointing to and thus can be used
> directly as an arg to the cpu_xxx ops.

Thank you for your attension.
please see my latest patch (http://marc.info/?l=linux-mm&m=121966459713193&w=2)
it do that.





\
 
 \ /
  Last update: 2008-08-26 01:33    [W:0.103 / U:1.040 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site