lkml.org 
[lkml]   [2008]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHSET 1/3 blk-for-2.6.28] block: misc fixes and improvements
On Mon, Aug 25, 2008 at 04:58:41PM +0200, Jens Axboe wrote:
> On Mon, Aug 25 2008, Greg KH wrote:
> > On Mon, Aug 25, 2008 at 06:15:35PM +0900, Tejun Heo wrote:
> > > Hello,
> > >
> > > This patchset contains the following five patches containing misc
> > > fixes and improvements.
> > >
> > > 0001-block-fix-partition-info-printouts.patch
> > > 0002-block-don-t-grab-block_class_lock-unnecessarily.patch
> > > 0003-block-use-class_dev_iterator-instead-of-class_for_e.patch
> > > 0004-block-allow-deleting-zero-length-partition.patch
> > > 0005-block-update-add_partition-error-handling.patch
> > >
> > > Recent block_class iteration updates 5c6f35c5..27f3025 introduced a
> > > few bugs and trivial user visible behavior change. 0001-0003 update
> > > those issues and simplify related code using new class iterator.
> >
> > The bugs should now be fixed in Linus's tree due to a fix from Kay,
> > right?
> >
> > The user visable behavior change, I missed that, sorry, that is a
> > regression, do you think it's a big deal to fix in 2.6.27?
> >
> > > 0004 fixes deletion of zero sized partitions.
> > >
> > > d805dda4 tried to fix error handling path in add_partition() but had a
> > > few problems. 0005 fixes those and moves busy partition check into
> > > add_partition().
> > >
> > > This patchset is against
> > >
> > > blk-for-2.6.28 (9abd7c437c02e7448fb1d2d3cfc0b9c1ab77cf2d)
> > > + [1] klist-dont-iterate-over-deleted-entries
> > > + [2] use-klist-for-class-device-list-and-implement-iterator
> > >
> > > and available in the following git tree.
> > >
> > > http://git.kernel.org/?p=linux/kernel/git/tj/misc.git;a=shortlog;h=block-misc-fixes
> > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git block-misc-fixes
> > >
> > > with the following combined diffstat
> >
> > I have no problem taking all of these patches as I did this original
> > work and don't want to burden Jens with this. Also, I'd like to work
> > off of the klist changes and class changes as that can be used in other
> > work that I want to do in the driver core.
> >
> > Jens any objection to me taking them? Do you also have changes in this
> > area that this needs to be merged with?
>
> It's actually easier for me to include them. Apart from a potential
> clash in linux-next there, there shouldn't be any problem in that.

Ok, that's fine. Feel free to add my:
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
to them.

I'll grab the klist and class patch and also add them to my trees, that
should be easy to resolve in the linux-next merges.

thanks,

greg k-h


\
 
 \ /
  Last update: 2008-08-25 23:57    [W:0.064 / U:5.416 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site