lkml.org 
[lkml]   [2008]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] x86_64 UV: Use LED to indicate CPU is active
Pavel Machek wrote:
> Hi!
>
>>> +/*
>>> + * Illuminate "activity" LED when CPU is going "active",
>>> + * extinguish when going "idle".
>>> + */
>>> +static int uv_idle(struct notifier_block *nfb, unsigned long action, void *junk)
>>> +{
>>> + if (action == IDLE_START)
>>> + uv_set_led_bits(0, LED_CPU_ACTIVITY);
>>> +
>>> + else if (action == IDLE_END)
>>> + uv_set_led_bits(LED_CPU_ACTIVITY, LED_CPU_ACTIVITY);
>>> +
>>> + return NOTIFY_OK;
>>> +}
>>> +
>>> +static struct notifier_block uv_idle_notifier = {
>>> + .notifier_call = uv_idle,
>>> +};
>>>
>>> +/*
>>> + * Initialize idle led callback function
>>> + */
>>> +static __init void uv_init_led_idle_display(void)
>>> +{
>>> + /* initialize timer for activity monitor */
>>> + idle_notifier_register(&uv_idle_notifier);
>>> +}
>> hm, i think this is a bad idea. While putting it into the go-to-idle
>
> Plus this really should not be uv-specific. We already have generic
> triggers.
>
> And you should really CC led maintainers!
> Pavel

Thanks for the pointers, I will definitely look into this.

(And sorry for not discovering the LED docs and maintainers earlier.)

Mike


\
 
 \ /
  Last update: 2008-08-25 19:57    [W:0.054 / U:0.360 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site