lkml.org 
[lkml]   [2008]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] [Patch 1/1] [Self Ptrace] System call notification with self_ptrace
    On 08/25, Pierre Morel wrote:
    >
    > @@ -550,6 +550,23 @@ asmlinkage long sys_ptrace(long request,
    > goto out;
    > }
    >
    > + if (request == PTRACE_SELF_ON) {
    > + task_lock(current);
    > + set_thread_flag(TIF_SYSCALL_TRACE);
    > + current->ptrace |= PT_SELF;

    I didn't read the whole patch, but this sets PT_SELF without PT_PTRACED
    (and without ptrace_attach).

    We have some "->ptrace != 0" checks which can misunderstand this. Just
    for example, suppose that the task does sys_ptrace(PTRACE_SELF_ON) and
    then its parent dies. I guess in that case forget_original_parent()
    will hit BUG_ON(p->ptrace), no?

    Oleg.



    \
     
     \ /
      Last update: 2008-08-25 18:51    [W:0.029 / U:30.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site