lkml.org 
[lkml]   [2008]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] Tracing/ftrace: Adds a marker to allow user comments


On Mon, 25 Aug 2008, Fr?d?ric Weisbecker wrote:

> 2008/8/25 Ingo Molnar <mingo@elte.hu>:
> >
> > * Fr?d?ric Weisbecker <fweisbec@gmail.com> wrote:
> >
> >> The documentation of mmiotrace describes an unimplemented feature
> >> which allows the user to write any comments on his trace by writing on
> >> a tracing/marker file. Here is an implementation of this idea.
> >>
> >> It applies on last version of tip tree.
> >
> > hmm ... have you looked at the (recently implemented) ftrace_printk()
> > facility?
> >
> > Ingo
> >
>
> Yes but I didn't want to use ftrace_printk() because it needs the "ip"
> parameter. User messages doesn't need this. But I reuse a part of the
> code of ftrace_printk and I splitted ftrace_printk() in two parts for
> this purpose: __ftrace_printk() and trace_print().
> I also reused the print_entry but with a new TRACE_MARK type to make
> the difference when it is time to send the entry to the pipe because
> user messages don't use ip.


Feel free to make TRACE_CONT work for you. I coupled it a little more than
I wanted to with the ftrace print. If you can find a nice way to make
TRACE_CONT a bit more generic, then feel free.

-- Steve



\
 
 \ /
  Last update: 2008-08-25 18:41    [W:0.067 / U:31.084 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site