Messages in this thread | | | Date | Mon, 25 Aug 2008 16:16:12 +1000 | From | Greg Ungerer <> | Subject | Re: [2.6 patch] m68knommu: let PCI depend on BROKEN |
| |
Hi Adrian,
Adrian Bunk wrote: > There exists blackfin hardware with PCI support, but the support > currently in the kernel fails to build starting with: > > <-- snip --> > > ... > CC init/main.o > In file included from dma-mapping.h:5, > from dma-mapping.h:52, > from dmaengine.h:29, > from skbuff.h:29, > from netlink.h:155, > from genetlink.h:4, > from genetlink.h:4, > from taskstats_kern.h:12, > from main.c:46: > dma-mapping.h: In function 'dma_supported': ma-mapping.h:24: > error: implicit declaration of function 'pci_dma_supported' > ... > make[2]: *** [init/main.o] Error 1
I think we should just remove the underlying comempci access code which is the only user of this (arch/m68knommu/kernel/comempci.c). Nobody has used it in a very long time. And the hardware itself is old, and completely brain-damaged by design.
Regards Greg
> <-- snip --> > > Signed-off-by: Adrian Bunk <bunk@kernel.org> > > --- > 3bdc07c86b6fd5fc18b7676a75c3ff907e00e807 > diff --git a/arch/m68knommu/Kconfig b/arch/m68knommu/Kconfig > index 2e7515e..77a5bdf 100644 > --- a/arch/m68knommu/Kconfig > +++ b/arch/m68knommu/Kconfig > @@ -702,6 +702,7 @@ menu "Bus options (PCI, PCMCIA, EISA, MCA, ISA)" > > config PCI > bool "PCI support" > + depends on BROKEN > help > Support for PCI bus. > > >
-- ------------------------------------------------------------------------ Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com SnapGear -- a Secure Computing Company PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
| |