lkml.org 
[lkml]   [2008]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on Intel hosts
Ingo Molnar <mingo@elte.hu> writes:

> * Avi Kivity <avi@qumranet.com> wrote:
>
>> Enabling Intel VT has the curious side effect whereby the INIT signal
>> is blocked. Rather than comment on the wisdom of this side effect,
>> this patch adds an emergency restart reboot notifier, and modifies the
>> kvm reboot notifier to disable VT on emergency reboot.

Please no notifiers in emergency_restart.

First emergency_restart is not supposed to work reliably it is a best effort tickle
the hardware thing.

Second and more importantly whenever someone adds a notifier instead of a proper hook
to one a code path like this it seems like avoiding building a proper interface so
and I believe keeps us from getting all of the logic and the heuristics right.

Why not just add a disable intel_vt if it is enabled call?

Eric


\
 
 \ /
  Last update: 2008-08-25 15:27    [W:0.060 / U:1.100 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site