lkml.org 
[lkml]   [2008]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/9] ide-disk: set_addressing() fixes
Hello.

Bartlomiej Zolnierkiewicz wrote:

> * Return -EIO if arg > 0 and LBA48 is unsupported.
>
> * No need to reset ->addressing.
>
> * Make ->addressing a single bit flag.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
[...]
> Index: b/include/linux/ide.h
> ===================================================================
> --- a/include/linux/ide.h
> +++ b/include/linux/ide.h
> @@ -507,7 +507,7 @@ struct ide_drive_s {
> unsigned sleeping : 1; /* 1=sleeping & sleep field valid */
> unsigned post_reset : 1;
> unsigned udma33_warned : 1;
> - unsigned addressing : 2; /* 0=28-bit, 1=48-bit, 2=48-bit doing 28-bit */
> + unsigned addressing : 1; /* 0=28-bit, 1=48-bit */
> unsigned wcache : 1; /* status of write cache */
> unsigned nowerr : 1; /* used for ignoring ATA_DF */
>

Don't you want to get rid of things like:

u8 lba48 = (drive->addressing == 1) ? 1 : 0;

MBR, Sergei




\
 
 \ /
  Last update: 2008-08-23 23:49    [from the cache]
©2003-2011 Jasper Spaans