Messages in this thread | | | Date | Sat, 23 Aug 2008 08:58:57 +1000 (EST) | From | James Morris <> | Subject | Re: [PATCH] TPM: update char dev BKL pushdown |
| |
On Fri, 22 Aug 2008, Serge E. Hallyn wrote:
> Quoting Rajiv Andrade (srajiv@linux.vnet.ibm.com): > > This patch removes the BKL calls from the TPM driver, which > > were added in the overall misc-char-dev-BKL-pushdown.patch, > > as they are not needed. Changed num_opens from an int to atomic_t. > > > > Signed-off-by: Mimi Zohar <zohar@us.ibm.com> > > Signed-off-by: Rajiv Andrade <srajiv@linux.vnet.ibm.com> > > Yes, this patch is good. > > It would also be good to rename num_opens. Note that it is always > either 0 or 1, and indicates whether someone has opened the chip. > So 'is_open' may make more sense.
And use atomic_set() instead of atomic_inc().
- James -- James Morris <jmorris@namei.org>
| |