lkml.org 
[lkml]   [2008]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC][PATCH 2/2] quicklist shouldn't be proportional to # of CPUs
    From
    From: Andrew Morton <akpm@linux-foundation.org>
    Date: Wed, 20 Aug 2008 23:46:15 -0700

    > On Wed, 20 Aug 2008 20:08:13 +0900 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
    >
    > > + num_cpus_per_node = cpus_weight_nr(node_to_cpumask(node));
    >
    > sparc64 allmodconfig:
    >
    > mm/quicklist.c: In function `max_pages':
    > mm/quicklist.c:44: error: invalid lvalue in unary `&'
    >
    > we seem to have a made a spectacular mess of cpumasks lately.

    It should explode similarly on x86, since it also defines node_to_cpumask()
    as an inline function.

    IA64 seems to be one of the few platforms to define this as a macro
    evaluating to the node-to-cpumask array entry, so it's clear what
    platform Motohiro-san did build testing on :-)


    \
     
     \ /
      Last update: 2008-08-21 09:15    [W:0.030 / U:31.444 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site