lkml.org 
[lkml]   [2008]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/10] AXFS: axfs_uncompress.c
On Thu, 21 Aug 2008, Jared Hulbert wrote:

> > Use DEFINE_MUTEX and drop the mutex_init() down in the init function.
>
> okay. by drop you mean delete?

Yes.

> > axfs_uncompress_init() and axfs_uncompress_exit() are only called during
> > init and exit of the module, no need for the initialized variable and the
> > functions can be annotated with __init and __exit.
>
> can be annotated or should be?

Should be. We only need them once during init and cleanup. If you want to
call axfs_uncompress_exit() from init_axfs_fs() to clean up in case of
register_filesystem failing, you can't annotate axfs_uncompress_exit()
with __exit.

Sven


\
 
 \ /
  Last update: 2008-08-21 16:59    [W:0.165 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site