Messages in this thread | | | Date | Thu, 21 Aug 2008 16:53:04 +0200 (CEST) | From | Sven Wegener <> | Subject | Re: [PATCH 10/10] AXFS: axfs_uncompress.c |
| |
On Thu, 21 Aug 2008, Jared Hulbert wrote:
> > Use DEFINE_MUTEX and drop the mutex_init() down in the init function. > > okay. by drop you mean delete?
Yes.
> > axfs_uncompress_init() and axfs_uncompress_exit() are only called during > > init and exit of the module, no need for the initialized variable and the > > functions can be annotated with __init and __exit. > > can be annotated or should be?
Should be. We only need them once during init and cleanup. If you want to call axfs_uncompress_exit() from init_axfs_fs() to clean up in case of register_filesystem failing, you can't annotate axfs_uncompress_exit() with __exit.
Sven
| |