lkml.org 
[lkml]   [2008]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 0/8] x86 dma_*_coherent rework patchset v2
From
On Wed, 20 Aug 2008 11:46:12 +0200
Ingo Molnar <mingo@elte.hu> wrote:

>
> * Joerg Roedel <joerg.roedel@amd.com> wrote:
>
> > Hi,
> >
> > this patchset reworks the dma_*_coherent functions in the DMA layer
> > for the x86 architecture. The patch series extends the existing DMA
> > backends with missing *coherent callbacks and simplifies the generic
> > function to basically only call the registered backend. This allows
> > future optimizations in hardware specific IOMMU implementations. The
> > code ist tested on AMD64 with AMD IOMMU, GART, SWIOTLB and NOMMU as
> > well as on my old 486 box. Muli tested the Calgary specific patch.
> >
> > Joerg
> >
> > Changes since v1:
> >
> > - fixed wrong logic in the pci-nommu alloc_coherent code
> > - moved dma_*_coherent to include/asm-x86/dma-mapping.h
> >
> > git diff --stat tip/master.. :
> >
> > arch/x86/kernel/amd_iommu.c | 2 -
> > arch/x86/kernel/pci-calgary_64.c | 14 ++++
> > arch/x86/kernel/pci-dma.c | 146 +-------------------------------------
> > arch/x86/kernel/pci-gart_64.c | 35 +++++++++-
> > arch/x86/kernel/pci-nommu.c | 62 ++++++++++++++++
> > include/asm-x86/dma-mapping.h | 47 ++++++++++---
> > 6 files changed, 149 insertions(+), 157 deletions(-)
>
> applied to tip/x86/iommu - thanks Joerg!
>
> Jesse, Fujita-san, do these changes look fine to you?

As I wrote in another mail, GART should return zeroed memory (keeping
the current behavior is better). Except for it, the patchset looks
fine.


\
 
 \ /
  Last update: 2008-08-21 16:25    [W:0.186 / U:0.040 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site