lkml.org 
[lkml]   [2008]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: silence section mismatch warning - uv_cpu_init

* Marcin Slusarz <marcin.slusarz@gmail.com> wrote:

> WARNING: vmlinux.o(.cpuinit.text+0x3cc4): Section mismatch in reference from the function uv_cpu_init() to the function .init.text:uv_system_init()
> The function __cpuinit uv_cpu_init() references
> a function __init uv_system_init().
> If uv_system_init is only used by uv_cpu_init then
> annotate uv_system_init with a matching annotation.
>
> uv_system_init was ment to be called only once, so make explicit by
> creating properly-named function and annotate it as __ref.
>
> Old code relied on uv_node_to_blade being initialized to 0, but it'a
> not initialized from anywhere and it's not static either.

this needs a proper fix as the patch is too ugly. If something should be
called only once then it has to go into a codepath that will only
initialize it once.

Ingo


\
 
 \ /
  Last update: 2008-08-21 12:37    [W:0.051 / U:1.240 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site