lkml.org 
[lkml]   [2008]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Tree for August 19 (mfd/ucb)
On Wed, 20 Aug 2008, KAMEZAWA Hiroyuki wrote:

> On Tue, 19 Aug 2008 17:16:58 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Tue, 19 Aug 2008 17:05:17 -0700
> > Randy Dunlap <randy.dunlap@oracle.com> wrote:
> >
> > > drivers/mfd/ucb1400 is a sound (AC97) driver, so it should depend
> > > on AC97_BUS, like in the patch below. However, with that patch in
> > > place, oldconfig goes belly up on me:
> > >
> > >
> > > linux-next-20080819> make ARCH=x86_64 O=X64 V=1 oldconfig
> > > make -C /local/linsrc/linux-next-20080819/X64 \
> > > KBUILD_SRC=/local/linsrc/linux-next-20080819 \
> > > KBUILD_EXTMOD="" -f /local/linsrc/linux-next-20080819/Makefile \
> > > oldconfig
> > > make -f /local/linsrc/linux-next-20080819/scripts/Makefile.build obj=scripts/basic
> > > /bin/sh /local/linsrc/linux-next-20080819/scripts/mkmakefile \
> > > /local/linsrc/linux-next-20080819 /local/linsrc/linux-next-20080819/X64 2 6
> > > GEN /local/linsrc/linux-next-20080819/X64/Makefile
> > > mkdir -p include/linux include/config
> > > make -f /local/linsrc/linux-next-20080819/scripts/Makefile.build obj=scripts/kconfig oldconfig
> > > scripts/kconfig/conf -o arch/x86/Kconfig
> > > make[2]: *** [oldconfig] Segmentation fault (core dumped)
> > > make[1]: *** [oldconfig] Error 2
> > > make: *** [sub-make] Error 2
> > >
> > >
> > >
> > > ---
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > >
> > > mfd/ucb1400 sound driver uses/depends on AC97_BUS:
> > >
> > > ERROR: "ac97_bus_type" [drivers/mfd/ucb1400_core.ko] undefined!
> > >
> > >
> > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > > cc: Samuel Ortiz <sameo@openedhand.com>
> > >
> > > ---
> > > drivers/mfd/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > --- linux-next-20080819.orig/drivers/mfd/Kconfig
> > > +++ linux-next-20080819/drivers/mfd/Kconfig
> > > @@ -52,6 +52,7 @@ config HTC_PASIC3
> > >
> > > config UCB1400_CORE
> > > tristate "Philips UCB1400 Core driver"
> > > + depends on AC97_BUS
> > > help
> > > This enables support for the Philips UCB1400 core functions.
> > > The UCB1400 is an AC97 audio codec.
> >
> > And this:
> >
> I still see SEGV in the latest mmtom (on x86-64)
>
> drivers/input/touchscreen/Kconfig has this definition.
>
> config TOUCHSCREEN_UCB1400
> tristate "Philips UCB1400 touchscreen"
> select AC97_BUS
> depends on UCB1400_CORE
> depends on GPIOLIB
>
> "select" should be "depends on" ,here ?

Thanks for pointing that out. Yes, that should be depends on IMO.
What is happening is that selecting AC97_BUS doesn't do anything
useful since CONFIG_SOUND is not enabled. Also, IMO we don't
want to select SOUND since it is a non-trivial subsystem and
should be enabled by user(s), not via select.

And changing this will probably fix the SEGV in kconfig...

--
~Randy


\
 
 \ /
  Last update: 2008-08-20 07:13    [W:0.037 / U:1.216 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site