lkml.org 
[lkml]   [2008]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Make gpiochip label const
On Tue, Aug 19, 2008 at 11:28:28AM -0700, Andrew Morton wrote:
> On Tue, 19 Aug 2008 15:13:47 +0400
> Dmitry <dbaryshkov@gmail.com> wrote:
>
> > 2008/8/19 Andrew Morton <akpm@linux-foundation.org>:
> > > On Sun, 17 Aug 2008 23:00:35 +0400 Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
> > >
> > >> On Tue, Aug 12, 2008 at 03:06:19PM -0700, David Brownell wrote:
> > >> > > From dbaryshkov@gmail.com Tue Aug 12 13:54:29 2008
> > >> > > From: Dmitry Baryshkov <dbaryshkov@gmail.com>
> > >> > > To: linux-kernel@vger.kernel.org
> > >> > > Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>,
> > >> > > David Brownell <dbrownell@users.sourceforge.net>
> > >> > > Subject: [PATCH] Make gpiochip label const
> > >> > > Date: Wed, 13 Aug 2008 00:39:48 +0400
> > >> > >
> > >> > > Mark gpiochip label as a const char pointer.
> > >> > >
> > >> > > Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
> > >> > > Cc: David Brownell <dbrownell@users.sourceforge.net>
> > >> >
> > >> > Acked-By: David Brownell <dbrownell@users.sourceforge.net>
> > >> >
> > >>
> > >> Sorry to disturb, but will this make into 2.6.27-rc? Thanks.
> > >>
> > >
> > > Ordinarily it would not. Is there some reason why you think it should?
> > >
> >
> > It fixes lots of warnings (one per each instance of code filling the gpio chip)
>
>
> That should have been in the changelog!
>
> When fixing warnings or compilations errors, the compiler output should
> also be in the changelog.

Thanks for the tip. It it written somewhere?

> I don't recall seeing such warnings and I cannot make them happen with
> drivers/gpio/gpiolib.c or with drivers/gpio/max732x.c or with
> drivers/gpio/pca953x.c. So we still don't know what this patch
> does :(

Because both mentioned drivers set gpiochip->label to non-const string.
You can check arch/arm/common/scoop.c for example of driver showing
different behaviour:

CHECK /home/lumag/tosa-tree/arch/arm/common/scoop.c
/home/lumag/tosa-tree/arch/arm/common/scoop.c:250:22: warning: incorrect type in assignment (different modifiers)
/home/lumag/tosa-tree/arch/arm/common/scoop.c:250:22: expected char *label
/home/lumag/tosa-tree/arch/arm/common/scoop.c:250:22: got char const *
CC arch/arm/common/scoop.o
/home/lumag/tosa-tree/arch/arm/common/scoop.c: In function ‘scoop_probe’:
/home/lumag/tosa-tree/arch/arm/common/scoop.c:250: warning: assignment discards qualifiers from pointer target type

>
> > and is pretty much small to honour inclusion IMO
>
> Well sure it's small. But converting things to `const' carries a
> fairly high risk of adding new warnings or breaking the build.

Should we stage it into linux-next?

--
With best wishes
Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-08-20 10:43    [W:0.046 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site