Messages in this thread | | | Subject | Re: VolanoMark regression with 2.6.27-rc1 | From | Peter Zijlstra <> | Date | Wed, 20 Aug 2008 16:33:16 +0200 |
| |
On Wed, 2008-08-20 at 18:32 +0400, adobriyan@gmail.com wrote: > On Wed, Aug 20, 2008 at 03:32:17PM +0200, Peter Zijlstra wrote: > > On Wed, 2008-08-20 at 12:51 +0200, Ingo Molnar wrote: > > > * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > > > > > > > And I must admit to having overlooked the effect on wake_affine.. > > > > > > > > Chris, could you see the effect of this on smp group fairness? > > > > Just realized my brainfart.. > > > > --- > > Subject: sched: load-balance bias fixes > > From: Peter Zijlstra <a.p.zijlstra@chello.nl> > > Date: Wed Aug 20 15:28:51 CEST 2008 > > > > Yanmin spotted a regression with my patch that introduces LB_BIAS: > > > > commit 93b75217df39e6d75889cc6f8050343286aff4a5 > > Author: Peter Zijlstra <a.p.zijlstra@chello.nl> > > Date: Fri Jun 27 13:41:33 2008 +0200 > > > > And I just spotted the brainfart - I should have replaced min/max with avg > > instead of removing it completely. > > > --- linux-2.6.orig/include/linux/kernel.h > > +++ linux-2.6/include/linux/kernel.h > > @@ -367,6 +367,12 @@ static inline char *pack_hex_byte(char * > > (void) (&_max1 == &_max2); \ > > _max1 > _max2 ? _max1 : _max2; }) > > > > +#define avg(x, y) ({ \ > > + typeof(x) _avg1 = ((x)+1)/2; \ > > + typeof(x) _avg2 = ((y)+1)/2; \ > > ITYM, typeof(y)
you thought right, I did mean that :-)
> > + (void) (&_avg1 == &_avg2); \ > > + _avg1 + _avg2; }) >
| |