lkml.org 
[lkml]   [2008]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] debug: fix BUILD_BUG_ON() for non-constant expressions
From
On Wed, Aug 20, 2008 at 03:31:53PM +0300, Boaz Harrosh wrote:
> Ingo Molnar wrote:
> > * Boaz Harrosh <bharrosh@panasas.com> wrote:
> >
> >> If the user of virtio_has_feature() must pass a compile-time constant
> >> then it must be converted to a MACRO, and then the BUILD_BUG_ON will
> >> work. Or it should be changed to a BUG_ON() if fbit is a runtime
> >> variable.
> >
>
> The use of __builtin_constant_p in inline functions is broken. This
> is because it will give different results depending on the -O level
> used. So I think that using it in the Kernel with inlines is plain
> broken. And should be discouraged.

See how kmalloc() works.



\
 
 \ /
  Last update: 2008-08-20 14:41    [W:0.064 / U:0.100 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site