Messages in this thread | | | Date | Wed, 20 Aug 2008 13:28:59 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH] dma-coherent: export dma_[alloc|release]_from_coherent methods |
| |
On Wed, Aug 20, 2008 at 12:18:11PM +0200, Ingo Molnar wrote: > > From ed0a6445788eed1fa836442730d8fe8ab1086629 Mon Sep 17 00:00:00 2001 > From: Ingo Molnar <mingo@elte.hu> > Date: Wed, 20 Aug 2008 12:16:09 +0200 > Subject: [PATCH] dma-coherent: export dma_[alloc|release]_from_coherent methods > > fixes modular builds: > > ERROR: "dma_alloc_from_coherent" [sound/core/snd-page-alloc.ko] undefined! > ERROR: "dma_release_from_coherent" [sound/core/snd-page-alloc.ko] undefined! > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > --- > kernel/dma-coherent.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/kernel/dma-coherent.c b/kernel/dma-coherent.c > index c1d4d5b..f013a0c 100644 > --- a/kernel/dma-coherent.c > +++ b/kernel/dma-coherent.c > @@ -124,6 +124,7 @@ int dma_alloc_from_coherent(struct device *dev, ssize_t size, > } > return (mem != NULL); > } > +EXPORT_SYMBOL(dma_alloc_from_coherent); > > /** > * dma_release_from_coherent() - try to free the memory allocated from per-device coherent memory pool > @@ -151,3 +152,4 @@ int dma_release_from_coherent(struct device *dev, int order, void *vaddr) > } > return 0; > } > +EXPORT_SYMBOL(dma_release_from_coherent);
Hmm, weird. I should have found this with the allmodconfig build test. Anyway, thanks for the fix.
Joerg
-- | AMD Saxony Limited Liability Company & Co. KG Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany System | Register Court Dresden: HRA 4896 Research | General Partner authorized to represent: Center | AMD Saxony LLC (Wilmington, Delaware, US) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
| |