lkml.org 
[lkml]   [2008]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/10] PPS: low level IRQ timestamps recording.

* Rodolfo Giometti <giometti@linux.it> wrote:

> Add low level IRQ timestamps recording for x86 (32 and 64 bits)
> platforms and enable UART clients in order to use it.
>
> This improves PPS precision. :)
>
> Signed-off-by: Rodolfo Giometti <giometti@linux.it>
> ---
> arch/x86/kernel/irq_32.c | 18 ++++++++++++++++++
> arch/x86/kernel/irq_64.c | 22 ++++++++++++++++++++--
> drivers/pps/Kconfig | 12 ++++++++++++
> drivers/pps/clients/pps-ldisc.c | 18 ++++++++++++++++++
> include/linux/pps.h | 1 +
> 5 files changed, 69 insertions(+), 2 deletions(-)

hm, NACK on this line of approach. If then this instrumentation should
be done at the genirq level (kernel/irq/*.c). Also, the #ifdefs are ugly
- please hide them in include files.

Ingo


\
 
 \ /
  Last update: 2008-08-20 12:35    [W:0.157 / U:3.844 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site