Messages in this thread | | | Date | Tue, 19 Aug 2008 20:02:25 -0700 | From | Philip Langdale <> | Subject | Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v5) |
| |
Henrique de Moraes Holschuh wrote: >> + toshiba_acpi.rfk_dev->state = RFKILL_STATE_OFF; > > Where did that RFKILL_STATE_OFF came from ? :-) Just get rid of it, you > override it four statements later anyway...
Left over from the first iteration. Now removed and diff updated.
> > Other than that, the rfkill bits look fine to me. >
Thanks. Anyone else care to voice an opinion? Should this go in through wireless-testing then?
--phil
| |