[lkml]   [2008]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 2/2] eeepc-laptop: Use standard interfaces
Hi Matthew!

On Wed, 20 Aug 2008, Matthew Garrett wrote:

> On Tue, Aug 19, 2008 at 10:18:29PM -0300, Henrique de Moraes Holschuh wrote:
> > 1. If the event has no bearing on compulsory hardware state changes (i.e.
> > the hardware won't change state by itself when the event happens, it is
> > really just reporting a simple key press that will do nothing by itself),
> > you just report the key as an event.
> Yes. That's all I do.
> > 2. If the hardware/firmware *ALSO* compulsory changes the rfkill state (i.e.
> > the event also means the real rfkill controller state probably changed), you
> > take the opportunity to do a forced immediate state poll and
> > rfkill_force_state() the new state.
> The firmware does not perform any compulsory change.

Then, I have no futher comments. Looks good to me.

"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh

 \ /
  Last update: 2008-08-20 03:35    [W:0.043 / U:6.308 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site